Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonddori
approved these changes
Jan 26, 2025
Comment on lines
+5
to
+9
| const IconBox = ({ leftIcon, content, rightIcon, handleClick, cursor = 'default' }: IconBoxProps) => { | ||
| return ( | ||
| <Flex align="center" gap="1" w="100%" h="40px" minH="40px" color="white" bg="orange_light" borderRadius="2xl"> | ||
| <IconButton as="div" flexShrink="0" aria-label="" icon={leftIcon} size="icon_md" variant="transparent" /> | ||
| <Text textStyle="bold_md" flex="auto" cursor="default" isTruncated> | ||
| <Text textStyle="bold_md" flex="auto" cursor={cursor} isTruncated> |
There was a problem hiding this comment.
다른 부분도 그렇고, default도 이렇게 직접 default라는 것을 명시해야 하나요? 말 그대로 기본값이라 그냥 둬도 된다고 생각이 들어서 명시해야 하는 이유가 궁금합니다!!
There was a problem hiding this comment.
아 저부분은 IconBox를 지금은 default 로 사용하지만 나중에는 pointer 나 text로 사용할 가능성도 있을 거라 생각되어서 저렇게 만들어 두었습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 요약
작업 상세 설명
리뷰 요구 사항
3분미리 보기